Messages in this thread Patch in this message | | | Date | Thu, 12 Dec 2002 17:27:46 -0500 | From | Jim Houston <> | Subject | Re: 2.5.51 nanosleep fails |
| |
Hi Linus, Marco, Julie, Everyone,
It really is broken. I just didn't try enough combinations.
Thanks Julie, the test suite really helps.
The problem is that nanosleep didn't check for the NULL pointer case and always tries to copy out the remaining time. The attached patch will fix this problem.
Jim Houston - Concurrent Computer Corp.
--- linux-2.5.51.orig/kernel/timer.c Thu Dec 12 17:08:30 2002 +++ linux-2.5.51.new/kernel/timer.c Thu Dec 12 16:59:10 2002 @@ -1040,7 +1040,7 @@ jiffies_to_timespec(expire, &t); ret = -ERESTART_RESTARTBLOCK; - if (copy_to_user(rmtp, &t, sizeof(t))) + if (rmtp && copy_to_user(rmtp, &t, sizeof(t))) ret = -EFAULT; /* The 'restart' block is already filled in */ } @@ -1067,7 +1067,7 @@ if (expire) { struct restart_block *restart; jiffies_to_timespec(expire, &t); - if (copy_to_user(rmtp, &t, sizeof(t))) + if (rmtp && copy_to_user(rmtp, &t, sizeof(t))) return -EFAULT; restart = ¤t_thread_info()->restart_block; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |