Messages in this thread | | | Date | Fri, 8 Nov 2002 00:11:11 +0530 | From | Dipankar Sarma <> | Subject | Re: Strange panic as soon as timer interrupts are enabled (recent 2.5) |
| |
On Wed, Nov 06, 2002 at 12:04:44PM -0800, Andrew Morton wrote: > > > > > > The softirq storage is initialised inside the CPU_UP_PREPARE call. > > > So we're ready for interrupts on that CPU when your architecture's > > > __cpu_up() is called. And no sooner than this. > > > > All interrupts, or just softints? > > > > I don't know. This sequencing really needs to be thought about > and written down, else we'll just have an ongoing fiasco trying > to graft stuff onto it. > > In this case I'd say "all interrupts". The secondary really > should be 100% dormant until all CPU_UP_PREPARE callouts have > been run and have returned NOTIFY_OK.
Well, the secondaries atleast cannot take the local timer interrupt since things hooked off it, like timers and RCU, are initiliazed using CPU_UP_PREPARE callouts. I would agree that it is unsafe to allow *any* interrupt until CPU_UP_PREPARE callouts are completed.
So, the current way of enabling interrupts in secondaries during delay calibration is unsafe. For that matter, it seems to me that with no proper mixed CPU support, calibrate_delay() for secondaries is meaningless.
Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |