lkml.org 
[lkml]   [2002]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [Linux-fbdev-devel] [BK fbdev updates]
From
Date
On Sat, 2002-11-02 at 07:29, James Simmons wrote:
>
> > James,
> >
> > I tried the patch, and it does produce a cleaner and smaller driver.
> > Overall, I like it. Some observations:
> >
> > 1. Without the fb_set_var() hook, switching from X messes up the
> > console. I would guess this will be addressed by the console?
>
> fbcon_switch has to be rewritten. I'm going threw the process of cleaning
> up the upper fbcon layer. Its such a mess. Yuck!!!
>
> > 2. Console panning/wrapping does not work. updatevar includes a check
> > "if (con == info->currcon)", and my guess is info->currcon is obsoleted
> > so the check always fails.
>
> It worked before. Strange. Do you mean for you console panning doesn't
> work on the visiable VC or a non visible VC?
>

Adding update_var to fbcon_switch fixes #1 and #2 for me. Attached is a
diff.
Also, using fbset to change video modes corrupts the console. Looking
at the code, the flow of control is from the console to fbdev only? Is
this correct? I agree with this, it's saner.

Tony

diff -Naur linux/drivers/video/console/fbcon.c linux-2.5.45-fbdev/drivers/video/console/fbcon.c
--- linux/drivers/video/console/fbcon.c Sun Nov 3 08:19:32 2002
+++ linux-2.5.45-fbdev/drivers/video/console/fbcon.c Sun Nov 3 08:18:56 2002
@@ -1604,8 +1604,6 @@
scrollback_max = 0;
scrollback_current = 0;

- update_var(unit, info);
-
if (p->dispsw->clear_margins && vt_cons[unit]->vc_mode == KD_TEXT)
p->dispsw->clear_margins(conp, p, 0);
if (logo_shown == -2) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [from the cache]
©2003-2011 Jasper Spaans