Messages in this thread | | | Date | Tue, 26 Nov 2002 20:54:27 +0100 | From | Sam Ravnborg <> | Subject | Re: [RFC] [PATCH] linux-2.5.49_subarch-cleanup_A2 |
| |
On Mon, Nov 25, 2002 at 05:40:58PM -0800, john stultz wrote: > If there are no further comments, I'll re-submit w/o the rfc bit.
One detail..
> +#VISWS subarch support > +mflags-$(CONFIG_VISWS) := -Iinclude/asm-i386/mach-visws > +mcore-$(CONFIG_VISWS) := mach-visws > +#default subarch support > +mflags-y += -Iinclude/asm-i386/mach-default > +ifndef mcore-y > + mcore-y := mach-default > endif Move the "mcore-y := mach-default" assignment above the block that deal with subarch. Then you do not need the "ifndef ..."
I recall that Linus previously have asked for shell commands when moving files - so consider including only the patch below and then a number of "mv arch/i386/X include/....". This makes it much more visible what you actually change.
Another alternative it to do it in bitkeeper, then it is visible from the cset that you move files (use bk mv).
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |