lkml.org 
[lkml]   [2002]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [TRIVIAL PATCH 2.5.48] Fixed ifdefs for a label in ncpfs/sock.c
    On Tue, Nov 19, 2002 at 07:02:17PM +0000, Dave Jones wrote:
    > On Tue, Nov 19, 2002 at 10:52:36AM -0800, Bob Miller wrote:
    > > diff -Nru a/fs/ncpfs/sock.c b/fs/ncpfs/sock.c
    > > --- a/fs/ncpfs/sock.c Tue Nov 19 10:31:17 2002
    > > +++ b/fs/ncpfs/sock.c Tue Nov 19 10:31:17 2002
    > > @@ -587,7 +587,9 @@
    > > }
    > > #endif
    > > type = ntohs(server->rcv.buf.type);
    > > +#ifdef CONFIG_NCPFS_PACKET_SIGNING
    > > cont:;
    > > +#endif
    > > if (type != NCP_REPLY) {
    > > if (datalen - 8 <= sizeof(server->unexpected_packet.data)) {
    >
    > Eww, personally I think the fix is worse than the warning.
    >
    > Dave
    I know. I personally hate #ifdef's and goto's... I spent more than a few
    minutes trying to find a "trivial" way to clean this up, but this was
    the best I could do without reorganizing LOTS of code (then it's not
    "trivial" anymore).

    --
    Bob Miller Email: rem@osdl.org
    Open Source Development Lab Phone: 503.626.2455 Ext. 17
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:31    [W:0.022 / U:1.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site