lkml.org 
[lkml]   [2002]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: privatize various functions in sched.h
On Fri, Nov 15, 2002 at 02:54:03AM -0800, William Lee Irwin III wrote:
>> This removes a bunch of inlines used only in isolated places from sched.h

On Fri, Nov 15, 2002 at 03:28:36AM -0800, William Lee Irwin III wrote:
> Hmm, while I'm at it, this applies atop the previous patch:
> This removes d_path() from sched.h and uninlines it. No idea why it was
> in sched.h in the first place (or why something this large is inlined).

Atop the d_path() removal patch:


__d_path() may be privatized since umsdos is broken anyway.

fs/dcache.c | 6 +++---
include/linux/dcache.h | 2 --
kernel/ksyms.c | 1 -
3 files changed, 3 insertions(+), 6 deletions(-)


diff -urpN cleanup-2.5.47-5/fs/dcache.c cleanup-2.5.47-6/fs/dcache.c
--- cleanup-2.5.47-5/fs/dcache.c 2002-11-15 02:45:02.000000000 -0800
+++ cleanup-2.5.47-6/fs/dcache.c 2002-11-15 10:19:33.000000000 -0800
@@ -1136,9 +1136,9 @@ void d_move(struct dentry * dentry, stru
*
* "buflen" should be %PAGE_SIZE or more. Caller holds the dcache_lock.
*/
-char * __d_path(struct dentry *dentry, struct vfsmount *vfsmnt,
- struct dentry *root, struct vfsmount *rootmnt,
- char *buffer, int buflen)
+static char * __d_path( struct dentry *dentry, struct vfsmount *vfsmnt,
+ struct dentry *root, struct vfsmount *rootmnt,
+ char *buffer, int buflen)
{
char * end = buffer+buflen;
char * retval;
diff -urpN cleanup-2.5.47-5/include/linux/dcache.h cleanup-2.5.47-6/include/linux/dcache.h
--- cleanup-2.5.47-5/include/linux/dcache.h 2002-11-15 02:41:37.000000000 -0800
+++ cleanup-2.5.47-6/include/linux/dcache.h 2002-11-15 10:19:01.000000000 -0800
@@ -238,8 +238,6 @@ extern struct dentry * __d_lookup(struct
/* validate "insecure" dentry pointer */
extern int d_validate(struct dentry *, struct dentry *);

-extern char * __d_path(struct dentry *, struct vfsmount *, struct dentry *,
- struct vfsmount *, char *, int);
extern char * d_path(struct dentry *, struct vfsmount *, char *, int);

/* Allocation counts.. */
diff -urpN cleanup-2.5.47-5/kernel/ksyms.c cleanup-2.5.47-6/kernel/ksyms.c
--- cleanup-2.5.47-5/kernel/ksyms.c 2002-11-15 02:43:58.000000000 -0800
+++ cleanup-2.5.47-6/kernel/ksyms.c 2002-11-15 10:19:50.000000000 -0800
@@ -167,7 +167,6 @@ EXPORT_SYMBOL(d_alloc_anon);
EXPORT_SYMBOL(d_splice_alias);
EXPORT_SYMBOL(d_lookup);
EXPORT_SYMBOL(d_path);
-EXPORT_SYMBOL(__d_path);
EXPORT_SYMBOL(mark_buffer_dirty);
EXPORT_SYMBOL(end_buffer_io_sync);
EXPORT_SYMBOL(__mark_inode_dirty);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:31    [W:0.067 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site