lkml.org 
[lkml]   [2002]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Kill obsolete and unused suspend/resume code from IDE
Hi!

> With the shutdown/cleanup split so the locking works out you might
> actually be able to do what you want (although I dont think you can get
> all the locking logic right yet because some of it is still hosed in the
> ide core). Also take a glance at the SC1200 driver with regards to the
> sysfs based power management handling.

SC1200 power managment looks sane. Questions:

Don't you need to wait for current operation to complete before
calling sc1200_spindown_drive?

I noticed you are not playing any tricks with inserting requests to
queues... This is basically what I was doing, so I like it.

Is sc1200_spindown_drive really sc1200 specific? Is there some problem
with doing suspend at ide.c layer, and resume (which is controller
specific) in each driver?

...Ugh. You are doing it as pci device, not as generic device. I
believe you should use sysfs directly.

Anyway I can live with this, and its way better than whats in there
just now.
Pavel

--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:31    [from the cache]
©2003-2011 Jasper Spaans