Messages in this thread | | | Date | Mon, 7 Oct 2002 16:13:58 -0300 (BRT) | From | Marcelo Tosatti <> | Subject | Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held |
| |
On Sat, 5 Oct 2002, Francois Romieu wrote:
> drivers/atm/iphase.c:tx_intr() > [...] > 1684 spin_lock_irqsave(&iadev->tx_lock, flags); > 1685 ia_tx_poll(iadev); > > ia_tx_poll -> > ia_hack_tcq -> > ia_enque_rtn_q -> > IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL); > > Driver does not seem maintained. Please apply. > > --- linux-2.4.20-pre9.orig/drivers/atm/iphase.c Sat Oct 5 15:51:28 2002 > +++ linux-2.4.20-pre9/drivers/atm/iphase.c Sat Oct 5 22:44:18 2002 > @@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q > } > > static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) { > - IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL); > + IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC); > if (!entry) return -1; > entry->data = data; > entry->next = NULL;
It seems correct. Have you tried to send this to Peter Wang <pwang@iphase.com> ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |