Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: Vicam/3com homeconnect usb camera driver | Date | Mon, 7 Oct 2002 00:01:55 +0200 |
| |
On Sunday 06 October 2002 19:35, John Tyner wrote: > > In vicam_v4l_open: > > > > Why is only the first control message checked for errors? > > The second one turns on the LED. I didn't check it because I figured the > LED actually turning on was not a big deal. Though, I suppose that if an > error occurred, that could be indicative of some other problem. >
Exactly.
> > vicam_usb_probe: > > > > __devinit ??? > > > > vicam_usb_disconnect: > > > > __devexit ??? > > I'm not sure I see the problem here. __devinit is only defined when HOTPLUG > is not defined, which seems right to me. If there is no HOTPLUG then we can > throw away the code as soon as init is completed. ...similar argument for > __devexit. Correct me if I'm wrong.
But usbcore will happily call probe if HOTPLUG is not defined and AFAICT usb will compile without HOTPLUG.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |