Messages in this thread | | | Date | Sat, 5 Oct 2002 03:33:40 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols |
| |
On Sat, Oct 05, 2002 at 03:25:24AM +0200, Matt D. Robinson wrote: > On 5 Oct 2002, Andi Kleen wrote: > |>"Matt D. Robinson" <yakker@aparity.com> writes: > |> > |>> diff -urN -X /home/bharata/dontdiff linux-2.5.40/arch/i386/kernel/i386_ksyms.c linux-2.5.40+lkcd/arch/i386/kernel/i386_ksyms.c > |>> --- linux-2.5.40/arch/i386/kernel/i386_ksyms.c Tue Oct 1 12:36:59 2002 > |>> +#if defined(CONFIG_X86) || defined(CONFIG_ALPHA) > |>> +EXPORT_SYMBOL(page_is_ram); > |>> +#endif > |> > |>This ifdef in i386_ksyms.c doesn't make much sense... > > If the rest of the architectures used page_is_ram(), this > wouldn't be a problem, but not all do. And since we use > it/need it, that's the reason for the addition.
My point was that in i386_ksyms you are always on i386 and never on alpha. So you can just remove that #ifdef.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |