Messages in this thread | | | Date | Fri, 4 Oct 2002 14:53:51 -0700 | From | Greg KH <> | Subject | Re: [BK PATCH] pcibios_* removals for 2.5.40 |
| |
On Fri, Oct 04, 2002 at 05:40:07PM -0400, Jeff Garzik wrote: > >diff -Nru a/drivers/char/rocket.c b/drivers/char/rocket.c > >--- a/drivers/char/rocket.c Fri Oct 4 13:47:29 2002 > >+++ b/drivers/char/rocket.c Fri Oct 4 13:47:29 2002 > >@@ -1993,7 +1993,7 @@ > > isa_boards_found++; > > } > > #ifdef CONFIG_PCI > >- if (pcibios_present()) { > >+ if (pci_present()) { > > if(isa_boards_found < NUM_BOARDS) > > pci_boards_found = init_PCI(isa_boards_found); > > } else { > > can be greatly simplified -- just simply all the code in the ifdef to > "if (isa_boards_found...) ...init_PCI..."
Heh, again, this driver needs some major work in regards to PCI cleanups, it's quite old. It can probably be converted over to use the drivers/serial core too.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |