Messages in this thread | | | Date | Tue, 29 Oct 2002 10:58:08 -0800 | From | Andrew Morton <> | Subject | Re: [RFC] generic_file_direct_IO() argument changes for AIO |
| |
Badari Pulavarty wrote: > > Hi, > > Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *" > to generic_file_direct_IO() and all direct_IO() ops. > > generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov, > loff_t offset, unsigned long nr_segs) > > Instead of adding a new argument, I propose replace > > "struct file *file" argument with "struct kiocb *iocb" > > One can get "filp" from iocb->ki_filp. > > Any objections ? >
OK by me.
BTW, while you're poking around in there could you please rename generic_direct_IO() to blockdev_direct_IO() and move generic_file_direct_IO() back into filemap.c? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |