lkml.org 
[lkml]   [2002]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]updated ipc lock patch
    On Mon, 28 Oct 2002, Rusty Russell wrote:

    > In message <Pine.LNX.4.44.0210271734450.7252-100000@blue1.dev.mcafeelabs.com> y
    > ou write:
    > > On Mon, 28 Oct 2002, Rusty Russell wrote:
    > >
    > > > +struct ipc_rcu_kmalloc
    > > > +{
    > > > + struct rcu_head rcu;
    > > > + /* "void *" makes sure alignment of following data is sane. */
    > > > + void *data[0];
    > > > +};
    > >
    > > Rusty, why not using gcc "aligned" keywords instead of black magic :
    > >
    > > void *data[0];
    >
    > I think it's clearer *why* it's being done than:
    >
    > struct ipc_rcu_kmalloc
    > {
    > struct rcu_head rcu;
    > } __attribute__((aligned(__alignof__(void *))));

    Well, not really Rusty. The above syntax uses documented gcc features
    already used inside the kernel, while the fact that void *data[0];
    enforces alignment it is not ( to my knowledge ) documented anywhere.
    You can also avoid the comment using the aligned syntax ...



    - Davide


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:30    [W:0.020 / U:0.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site