Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH]updated ipc lock patch | Date | Mon, 28 Oct 2002 15:10:10 +1100 |
| |
In message <Pine.LNX.4.44.0210271734450.7252-100000@blue1.dev.mcafeelabs.com> y ou write: > On Mon, 28 Oct 2002, Rusty Russell wrote: > > > +struct ipc_rcu_kmalloc > > +{ > > + struct rcu_head rcu; > > + /* "void *" makes sure alignment of following data is sane. */ > > + void *data[0]; > > +}; > > Rusty, why not using gcc "aligned" keywords instead of black magic : > > void *data[0];
I think it's clearer *why* it's being done than:
struct ipc_rcu_kmalloc { struct rcu_head rcu; } __attribute__((aligned(__alignof__(void *))));
And simpler than:
struct ipc_rcu_kmalloc { struct rcu_head rcu; /* "void *" makes sure alignment of following data is sane. */ char data[0] __attribute__((aligned(__alignof__(void *)))); };
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |