Messages in this thread | | | Date | Fri, 25 Oct 2002 14:53:15 -0200 (BRST) | From | Rik van Riel <> | Subject | Re: [PATCH]updated ipc lock patch |
| |
On Thu, 24 Oct 2002, Andrew Morton wrote:
> And it seems that if the kmalloc fails, we decide to leak some > memory, yes? > > If so it would be better to use GFP_ATOMIC there. Avoids any > locking problems and also increases the chance of the allocation > succeeding. (With an explanatory comment, naturally :)).
Actually, under memory load GFP_KERNEL will wait for the memory to become available, while GFP_ATOMIC will fail.
Using GFP_ATOMIC here will probably increase the risk of a memory leak.
regards,
Rik -- Bravely reimplemented by the knights who say "NIH". http://www.surriel.com/ http://distro.conectiva.com/ Current spamtrap: <a href=mailto:"october@surriel.com">october@surriel.com</a>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |