[lkml]   [2002]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Advanced TCA SCSI/FC disk hotswap driver for kernel 2.5.44

    Erik Andersen wrote:

    >On Wed Oct 23, 2002 at 04:27:06PM -0700, Steven Dake wrote:
    >>Attached is an update of the Advanced TCA disk hotswap driver to provide
    >>disk hotswap
    >>support for the Linux Kernel 2.5.43. Hotswap targets include both SCSI
    >>and FibreChannel.
    >This looks (in parts) similar to the patch I made to make 1394
    >hotswapping work correctly.
    >The patch is vs 2.4, but you get the idea. Anyway, I think it
    >would make more sense for you to fixup proc_scsi_gen_write() to
    >make the old hotswap interface (you know the
    > echo "scsi add-single-device 0 1 2 3" >/proc/scsi/scsi
    > echo "scsi remove-single-device 0 1 2 3" >/proc/scsi/scsi
    I wanted to seperate the hotswap functionality from the main scsi code.
    I also feel
    that hotswap shouldn't be a function of proc. Also, the patch I
    supplied supports
    fibrechannel hotswap as well. Your patch looks pretty good and I plan
    to change
    the proc_scsi_gen_write() to use the scsi hotswap commands in hotswap.c.
    advantage of this technique is that the HBA_ptr doesn't have to be known
    this generic code can go in the actual routine instead of the proc
    parsing routine).
    The final advantage of having seperate comands is less time is spent
    passing and
    parsing text data. Plus my patch provides usage information for those
    that don't
    or can't read the source code to understand the interface :)

    As far as I'm concerned, I'd be happy to entirely remove the
    code, but I think that might confuse some people.

    As for the interfaces stomping each other, I've added correct locking to
    to ensure that the host_queue is locked during access so changes to it
    cannot occur
    during hotswap operations. This keeps a scsi_device entry from being
    deleted while
    the list is being parsed, resulting in bad magic.

    >one) and make it use your new hotswap code. Otherwise the two
    >interfaces could easily stomp on each other and hose up the
    >kernel when mucking about with scsi host internals.
    > -Erik
    >Erik B. Andersen
    >--This message was written using 73% post-consumer electrons--

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:30    [W:0.022 / U:5.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site