lkml.org 
[lkml]   [2002]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.44: lkcd (9/9): dump driver and build files
On Tue, Oct 22 2002, Suparna Bhattacharya wrote:
> On Mon, 21 Oct 2002 19:43:20 +0530, Christoph Hellwig wrote:
>
>
> >> +
> >> + if ((dump_bio = kmalloc(sizeof(struct bio), GFP_KERNEL)) == NULL) { +
> >> DUMP_PRINTF("Cannot allocate bio\n"); + retval = -ENOMEM;
> >> + goto err2;
> >> + }
> >
> > Shouldn't you use the generic bio allocator?
> >
>
> Not sure that this should come from the bio mempool. Objects
> allocated from the mem pool are expected to be released back to
> the pool within a reasonable period (after i/o is done), which is
> not quite the case here.
>
> Dump preallocates the bio early when configured and holds on to
> it all through the time the system is up (avoids allocs at
> actual dump time). Doesn't seem like the right thing to hold
> on to a bio mempool element that long.

Definitely, one must not use the bio pool for long term allocations.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [from the cache]
©2003-2011 Jasper Spaans