lkml.org 
[lkml]   [2002]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [2.5 patch] allow only one Toshiba Type-O IR Port driver in the kernel
From
On Sun, Oct 20, 2002 at 04:44:11PM +0200, Adrian Bunk wrote:
>
> Trying to compile both Toshiba Type-O IR Port drivers into the kernel
> fails with the following error:
>
> <-- snip -->
>
> ...
> ld -m elf_i386 -r -o drivers/net/irda/built-in.o ...
> drivers/net/irda/donauboe.o: In function `toshoboe_init':
> drivers/net/irda/donauboe.o(.init.text+0x0): multiple definition of
> `toshoboe_init'
> drivers/net/irda/toshoboe.o(.init.text+0x0): first defined here
> make[3]: *** [drivers/net/irda/built-in.o] Error 1
>
> <-- snip -->
>
> The following patch allows the builing of the old driver only when the new
> one isn't compiled into the kernel.
>
> Additionally it indents three lines inside an if ... fi that weren't
> indented.

Adrian,

Thanks very much for the report. I personally uses modules,
and I would prefer the ability to compile both modules, so that people
can try both without having to recompile their kernel.
I think a much better patch (and simpler in the long term)
would be to just rename 'toshoboe_init' to 'donauboe_init' (plus the
few other offending function). This is a case where the name doesn't
really matter.
What do you think ?

Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [from the cache]
©2003-2011 Jasper Spaans