Messages in this thread | | | Subject | Re: [PATCH] fixes for building kernel using Intel compiler | From | Alan Cox <> | Date | 21 Oct 2002 13:48:25 +0100 |
| |
On Sat, 2002-10-19 at 00:48, Nakajima, Jun wrote: > -/* Enable FXSR and company _before_ testing for FP problems. */ > - /* > - * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned. > - */ > - if (offsetof(struct task_struct, thread.i387.fxsave) & 15) { > - extern void __buggy_fxsr_alignment(void); > - __buggy_fxsr_alignment(); > - } > if (cpu_has_fxsr) { > printk(KERN_INFO "Enabling fast FPU save and restore... ");
So you back out a test that is pretty much essential to catch misaligned stuff if we do get something wrong in our alignments or due to compiler suprises and hope it doesnt happen ?
This isnt "fixing" this is the mad axeman at work. Linus this patch should not go in as it is
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |