[lkml]   [2002]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] cli()/sti() fix for drivers/net/depca.c
    Denis Vlasenko <> :
    > Ho to do it properly? Make a copy on stack under lock, release lock,
    > proceed with copy_to_user? That's 88 bytes at least...

    Please see ETHTOOL_GSTATS usage in drivers/net/8139cp.c.

    > > - on SMP, pktStat can be updated while the copy progresses, see depca_rx().
    > Should I place these pktStat updates under lp->lock?

    You may.

    depca_rx() looks strange:
    buf = skb_put(skb, len);
    if (buf[0] & ...)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:29    [W:0.022 / U:0.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site