lkml.org 
[lkml]   [2002]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] Add extended attributes to ext2/3
> On Wed, Oct 16, 2002 at 11:05:39AM -0600, Andreas Dilger wrote:
> > Err, wouldn't that be a 2TB FILE limit, and not a FILESYSTEM limit?
>
> Yes, sorry about that.
>
> I just took a quick look at this, and the limit is unfortunately
> fundamental to the VFS; the st_blocks in struct inode and struct kstat
> is an unsigned long, which means that we're stuck with the 2TB limit
> for *all* filesystems, even using the LFS API. (Or rather, as you
> point out, since no one apparently is doing any overflow checking, so
> st_blocks will just be incorrect, even to callers using the stat64
> call.)
>
> A quick fix would be to make st_blocks in struct inode and struct
> kstat take a __u64 instead of a unsigned long, but it will have a
> performance impact. What do folks think?
I'd vote for it. And also for storing used space in bytes - then you
can remove i_bytes field quota is using from inode and inode_set_bytes,
inode_add_bytes and such inline functions from fs.h ...

Honza

--
Jan Kara <jack@suse.cz>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [W:0.049 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site