Messages in this thread | | | Subject | Re: [PATCH] fixes for building kernel using Intel compiler | From | Andi Kleen <> | Date | 19 Oct 2002 02:07:41 +0200 |
| |
"Nakajima, Jun" <jun.nakajima@intel.com> writes:
> -asmlinkage int sys_iopl(unsigned long unused) > +asmlinkage int sys_iopl(struct pt_regs * regs) > { > - struct pt_regs * regs = (struct pt_regs *) &unused;
The change is wrong. The pt_regs are passed by value on the stack, not by reference.
> > -/* Enable FXSR and company _before_ testing for FP problems. */ > - /* > - * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned. > - */ > - if (offsetof(struct task_struct, thread.i387.fxsave) & 15) { > - extern void __buggy_fxsr_alignment(void); > - __buggy_fxsr_alignment(); > - }
Why does that not work? IMHO it is legal ISO-C
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |