lkml.org 
[lkml]   [2002]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] thread-aware coredumps, 2.5.43-C3
    Date
    I think I fixed it to set namesz to 5, with the +1 it was making it 6.  My
    patch is supposed to remove the +1.

    The value for men-name for the extended registers case is "LINUX".

    --mgross

    > On Thursday 17 October 2002 05:48 pm, Daniel Jacobowitz wrote:
    > > You'd have to ask Mark Kettenis about that. Mark, it looks like you
    > > updated the kernel to write namesz == 6, but BFD still expects 5 (and
    > > elfcore_write_note writes 6)? Shouldn't we accept both, anyway?
    > >
    > > On Thu, Oct 17, 2002 at 05:07:41PM -0400, mgross wrote:
    > > > This patch is working pretty well for me with only one problem, which
    > > > seems to have happened indepently of Ingo's patch.
    > > >
    > > > Extended floating point note sections are no longer getting recognized
    > > > by GDB 5.x.
    > > >
    > > > After a bit of poking around in the GDB 5.2.1 code (line 6399
    > > > bfd/efl.c) I noticed that there is a n_namesz test for the reg-xfp
    > > > section parsing.
    > > >
    > > > The following minor tweak on top of Ingo's patch to binfmt_elf.c fixes
    > > > the problem.
    > > >
    > > > diff -urN -X dontdiff linux-2.5.43/fs/binfmt_elf.c
    > > > linux-2.5.43.xfp/fs/binfmt_elf.c
    > > > --- linux-2.5.43/fs/binfmt_elf.c Thu Oct 17 16:54:13 2002
    > > > +++ linux-2.5.43.xfp/fs/binfmt_elf.c Thu Oct 17 16:53:00 2002
    > > > @@ -964,7 +964,9 @@
    > > > {
    > > > struct elf_note en;
    > > >
    > > > - en.n_namesz = strlen(men->name) + 1;
    > > > + en.n_namesz = strlen(men->name);
    > > > + /* en.n_namesz = strlen(men->name) + 1; gdb checks namez and the
    > > > + 1 */ + /*breaks xfp core file
    > > > note sections. */ en.n_descsz = men->datasz;
    > > > en.n_type = men->type;
    > > >
    > > >
    > > >
    > > > I don't know when this +1 was added to writenote binfmt_elf.c or why.
    > > > I do know that newer than July and it isn't in 2.4
    > > >
    > > > If there the + 1 is needed of others then we may need to special case
    > > > the NT_PRXFPREG note sections.
    > > >
    > > > --mgross

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:30    [W:0.021 / U:93.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site