[lkml]   [2002]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] superbh, fractured blocks, and grouped io
    On Mon, Oct 14, 2002 at 03:51:00PM +0200, Jens Axboe wrote:

    Just a couple niggles, really. Looking good.

    > /*
    > - * First step, 'identity mapping' - RAID or LVM might
    > - * further remap this.
    > + * detach each bh and resubmit, or completely and if its a grouped bh
    > */

    The last line of the comment means "completely fail if its
    grouped", right?

    > +#define MAX_SUPERBH 65535 /* must fit info ->b_size right now */

    Why not sizeof(b_size) in case we ever care?

    > +extern int submit_bh_linked(int, struct buffer_head *);
    > +extern int submit_bh_grouped(int, struct buffer_head *);

    Why aren't these EXPORT_SYMBOL(), given that a third party
    driver may wish to use them (eg, a filesystem doing its own O_DIRECT



    "We'd better get back, `cause it'll be dark soon,
    and they mostly come at night. Mostly."

    Joel Becker
    Senior Member of Technical Staff
    Oracle Corporation
    Phone: (650) 506-8127
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:30    [W:0.021 / U:17.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site