lkml.org 
[lkml]   [2002]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] superbh, fractured blocks, and grouped io
On Mon, Oct 14, 2002 at 03:51:00PM +0200, Jens Axboe wrote:

Just a couple niggles, really. Looking good.

> /*
> - * First step, 'identity mapping' - RAID or LVM might
> - * further remap this.
> + * detach each bh and resubmit, or completely and if its a grouped bh
> */

The last line of the comment means "completely fail if its
grouped", right?

> +#define MAX_SUPERBH 65535 /* must fit info ->b_size right now */

Why not sizeof(b_size) in case we ever care?

> +extern int submit_bh_linked(int, struct buffer_head *);
> +extern int submit_bh_grouped(int, struct buffer_head *);

Why aren't these EXPORT_SYMBOL(), given that a third party
driver may wish to use them (eg, a filesystem doing its own O_DIRECT
work)?

Joel

--

"We'd better get back, `cause it'll be dark soon,
and they mostly come at night. Mostly."

Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [from the cache]
©2003-2011 Jasper Spaans