lkml.org 
[lkml]   [2002]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pcnet32 cable status check
Thus Spake Jeff Garzik:
>
>Looks good ;-)

Thanks,

>
>One small thing -- since you appear to test all cases for (lp->mii)
>before calling mod_timer, I don't think you need to test lp->mii inside
>the timer...

Well, the reason I left that in there was so that another person could add
functionality to the watchdog if they wanted on a non-mii enabled card
without having to know that the check would need to be added. If that's not
that big a deal, I can remove it...

>As Felipe mentioned, using the link interrupt instead of a timer is
>preferred -- but my own preference would be to apply your patch with the
>small remove-lp->mii-check fixup, and then investigate the support of
>link interrupts. The reasoning is that, pcnet32 covers a ton of chips,
>and not all may support a link interrupt.
>
> Jeff
>
>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.102 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site