Messages in this thread | | | Date | Wed, 9 Jan 2002 02:32:43 -0700 | From | Andreas Dilger <> | Subject | Re: [PATCH] Oops with eject and cdrom affects 2.4 & 2.5 |
| |
On Jan 09, 2002 11:07 +0200, Zwane Mwaikambo wrote: > On Wed, 9 Jan 2002, Jens Axboe wrote: > > Yes, just kill the printk instead. > > Here are patches for 2.5.2-pre10 and 2.4.18-pre2 respectively > > --- linux-2.5.2-pre10/drivers/ide/ide-cd.c.orig Wed Jan 9 10:18:40 2002 > +++ linux-2.5.2-pre10/drivers/ide/ide-cd.c Wed Jan 9 10:28:22 2002 > @@ -1398,11 +1398,8 @@ > ide_init_drive_cmd (&req); > req.flags = REQ_PC; > req.special = (char *) pc; > - if (ide_do_drive_cmd (drive, &req, ide_wait)) { > - printk("%s: do_drive_cmd returned stat=%02x,err=%02x\n", > - drive->name, req.buffer[0], req.buffer[1]); > - /* FIXME: we should probably abort/retry or something */ > - } > + ide_do_drive_cmd (drive, &req, ide_wait); > +
Hmm, it would appear that this patch is "losing information", about the fact that there could be an error here, and the FIXME that it should be retried. If anything, I would just remove the printk and leave the FIXME.
Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |