lkml.org 
[lkml]   [2002]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subjectext3 umount oops in 2.5.2-pre10
From
Date

It looks like ext3 does not work if you do not use an external
journal device - the journal_bdev field is not initialized and
ext3_put_super goes belly up:


At the very least it needs this:

===========================================================================
Index: linux/fs/ext3/super.c
===========================================================================

--- /usr/tmp/TmpDir.13226-0/linux/fs/ext3/super.c_1.6 Wed Jan 9 12:38:48 2002
+++ linux/fs/ext3/super.c Wed Jan 9 12:26:00 2002
@@ -429,7 +429,7 @@
J_ASSERT(list_empty(&sbi->s_orphan));

invalidate_bdev(sb->s_bdev, 0);
- if (sbi->journal_bdev != sb->s_bdev) {
+ if (sbi->journal_bdev && (sbi->journal_bdev != sb->s_bdev)) {
/*
* Invalidate the journal device's buffers. We don't want them
* floating about in memory - the physical journal device may


--

Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:15    [W:0.087 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site