lkml.org 
[lkml]   [2002]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)
Date
On January 7, 2002 10:25 pm, Jeff Garzik wrote:
> Daniel Phillips wrote:
> > The two main problems I see with this are:
> >
> > - If a filesystem doesn't want to use genericp_ip/sbp then fs.h has
> > to know about it. Why should fs.h know about every filesystem in
> > the world?
>
> We keep type information through this method. There is no ugly casting.

There is a far uglier 1) tying of fs.h to every filesystem in the world 2) a
gratuitous extra pointer dereference and 3) a pointer field wasted in every
inode.

In the ugly contest, you win, hands down.

--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.100 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site