Messages in this thread | | | From | Daniel Phillips <> | Subject | Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7) | Date | Tue, 8 Jan 2002 04:06:36 +0100 |
| |
On January 7, 2002 10:25 pm, Jeff Garzik wrote: > Daniel Phillips wrote: > > The two main problems I see with this are: > > > > - If a filesystem doesn't want to use genericp_ip/sbp then fs.h has > > to know about it. Why should fs.h know about every filesystem in > > the world? > > We keep type information through this method. There is no ugly casting.
There is a far uglier 1) tying of fs.h to every filesystem in the world 2) a gratuitous extra pointer dereference and 3) a pointer field wasted in every inode.
In the ugly contest, you win, hands down.
-- Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |