Messages in this thread | | | Date | Mon, 7 Jan 2002 00:24:26 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [patch] truncate fixes |
| |
On Sun, 6 Jan 2002, Andrew Morton wrote:
> Andrea Arcangeli wrote: > > > > I prefer my fix that simply recalls the ->truncate callback if -ENOSPC > > is returned by prepare_write. vmtruncate seems way overkill, > > No opinion on that here. This is what was in -ac. Perhaps Al can > comment?
a) It's obviously correct b) it's a friggin error-handling path and I'll take correctness over anything here.
Keep in mind that you want to zero the area out, so at the very least truncate_inode_pages() + ->truncate() are needed. And locking/ordering consideration here are tricky enough to make duplicating them a Bad Thing(tm).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |