Messages in this thread | | | Date | Fri, 4 Jan 2002 23:27:15 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [FIX] missing piece from fs/super.c in -pre8 |
| |
On Fri, 4 Jan 2002, Linus Torvalds wrote:
> > On Fri, 4 Jan 2002, Alexander Viro wrote: > > > > Linus, I doubt that making the thing inline was a good idea. Reason: for > > filesystems like NFS we almost definitely want something like server name > > + root path to identify the superblock. And that can easily grow past > > 32 bytes. > > Since it is only used for printouts, I'd much rather have simpler code. > Especially since I couldn't convince myself that all users in your version > even initialized the dang pointer.
Set to NULL when we allocate superblock. Allocated and set by get_sb_bdev() (which takes care of block filesystems) Allocated and set by nfs_read_super() (which takes care of NFS). That covers all users...
> There is nothing wrong with having a requirement that informational stuff > be limited to X characters..
In principle - yes...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |