[lkml]   [2002]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [CFT] [JANITORIAL] Unbork fs.h
    On Jan 03, 2002  15:07 -0200, Arnaldo Carvalho de Melo wrote:
    > Em Thu, Jan 03, 2002 at 06:05:19PM +0100, Daniel Phillips escreveu:
    > > On January 3, 2002 05:36 pm, Arnaldo Carvalho de Melo wrote:
    > > > Maybe CodingStyle should have an entry for this, I'd vote for this style:
    > > >
    > > > static inline struct inode *new_inode(struct super_block *sb)
    > >
    > > OK, I'll revise it to that style. Shall we start an official janitor's
    > > style guide? ;-)
    > Nah, I'll try and submit some patches do CodingStyle, for discussion. Hey,
    > people here _love_ to discuss important things like coding style, dontcha?

    While you are at it, the following patch to scripts/Lindent makes it do the
    right thing as well. From what I can see, the following is more consistent
    with the actual practise in the kernel code. Sadly, indent (v2.2.4) will
    break the indenting of any line with a colon (e.g. labels, named struct
    initialization), so it is not possible to just run Lindent on the whole

    I removed the following two options:
    -bs: Put a space between sizeof and its argument.
    -psl: Put the type of a procedure on the line before its name.

    I added the following options:
    -nbbo: don't prefer to break lines before boolean operators
    -ci8: indent continuation lines 8 characters
    -ncs: Do not put a space after cast operators.
    -lps: Leave space between # and preprocessor directive.
    -pmt: Preserve access and modification times on output files.
    -npro: Do not read files.

    diff -u linux.orig/scripts/Lindent linux/scripts/Lindent
    --- linux.orig/scripts/Lindent Wed Nov 28 23:25:14 2001
    +++ linux/scripts/Lindent Thu Jan 3 12:10:00 2002
    @@ -1,2 +1,37 @@
    -indent -kr -i8 -ts8 -sob -l80 -ss -bs -psl "$@"
    +indent -kr -nbbo -ci8 -ncs -i8 -l80 -lps -pmt -npro -sob -ss -ts8 "$@"
    Cheers, Andreas
    Andreas Dilger

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:15    [W:0.032 / U:56.544 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site