Messages in this thread Patch in this message | | | Date | Mon, 28 Jan 2002 20:29:18 +0300 | From | Hans Reiser <> | Subject | [PATCH] ReiserFS 2.5 Update Patch Set 4 of 25 |
| |
This set of patches of which this is one will update ReiserFS in 2.5 to contain all bugfixes applied to 2.4 plus allow relocating the journal plus uuid support plus fix the kdev_t compilation failure.
04-bitmap-range-checking.diff Check that block number are going to free in a bitmap makes sense. This avoids oops after trying to access bitmap for wild block number.
The other patches in this set are:
01-reiserfs-kdev-fixed.diff kdev_t fixes to comply with new interface.
02-reiserfs-journal-relocation.diff Support for relocated journals.
03-check_nlink_in_reiserfs_read_inode2.diff It is possible that knfsd is trying to access inode of a file that is being removed from the disk by some other thread. As we update sd on unlink all that is required is to check for nlink here. This bug was first found by Sizif when debugging SquidNG/Butterfly, forgotten, and found again after Philippe Gramoulle <philippe.gramoulle@mmania.com> reproduced it.
More logical fix would require changes in fs/inode.c:iput() to remove inode from hash-table _after_ fs cleaned disk stuff up and in iget() to return NULL if I_FREEING inode is found in hash-table. We await Al Viro doing the more logical fix, and we provide this fix so that users can work while we wait for the better fix.
04-bitmap-range-checking.diff Check that block number are going to free in a bitmap makes sense. This avoids oops after trying to access bitmap for wild block number.
05-prepare_for_delete_or_cut-cleanup.diff Patch by Chris Mason <Mason@Suse.COM>. prepare_for_delete_or_cut() tries to find the unformatted node in the buffer cache to make sure it isn't in use. Since unformatted nodes are never in the buffer cache, this check is useless. The page locking done by mm/vmscan.c:vmtruncate protects us from truncating away pages that are in use, so it is safe to just remove the bogus check from our code.
Since the get_hash_table was also the reason for the repeat loop, this patch removes it as well.
This should make file deletes faster, at the very least it cuts down on CPU overhead for deletes/truncates.
06-E-cleanup.diff There is always place for Yet Another Cleanup of Reiserfs Code.
07-mmaped_data_loss_fix.diff fixes a bug first noticed using a Freebsd nfs testing tool. When writing to a previously mmaped-filled hole in file, and then writing with write() there again, page that write() hits loses mmap-written content.
08-unlink-truncate-opened.diff Fixes long-standing problem in reiserfs, when disk space gets leaked if crash occurred when some process hold a reference to unlinked file.
It's possible to unlink file that is still opened by some process. In this case, body of file is actually removed at the time of last close. If crash occurs in between last unlink (when directory entry for this file is removed) and last close, body doesn't get unlinked and "disk-space-leak" occurs. To prevent this, unlink-truncate-opened patch stores in the tree a special record at the time of last unlink. This record is a form of logical logging and will be either removed during following close, or replayed during next mount after a crash.
09-chown-32-bit-fix.diff Reiserfs 3.5 disk format can only store 16 bit uid/gid inside stat-data. This patch adds error checking so that EINVAL is returned on attempt to change uid/gid of an old file to value that doesn't fit into 16 bit, in stead of silently truncating it into 16 bit.
10-journal-preallocated.diff Patch by Chris Mason for bug found and debugged by Anne Milicia (milicia@missioncriticallinux.com): don't run preallocated blocks through journal_mark_freed() and don't corrupt i_prealloc_block during __discard_prealloc().
11-double-replay.diff Patch by Chris Mason to avoid duplicate replay of last flushed transaction.
12-infinite-replay.diff Patch to break infinite loop in journal_read() in the case when the journal log area is completely filled with transactions.
13-scan_magic_cleanup.diff Fixes a problem with v3.6 fs mounted readonly and then remounted rw.
14-map_block_for_writepage_highmem_fix.diff Fixes erroroneous page access before making sure page is really accessable. Bug can be triggered only on highmem sysetms.
15-long_symlinks_fix.diff Symlink-body length check was made against an incorrect value, allowing for too long nodes to be inserted into tree. This might lead to obscure warnings in some cases.
16-tail_data_corruption_on_mempressure.diff Fixes a bug when mmap-write to a file tail and subsequent read cause written data to be lost due to page-cache interacting mistake in low number of free buffers situation.
17-kreiserfsd-sleep-timeout.diff Correct a typo in fs/reiserfs/journal.c: interruptible_sleep_on_timeout() takes timeout in jiffies, rather than seconds.
18-corrupted_fs_panic_on_lookup_fix.diff Certain disk corruptions and i/o errors may cause lookup() to panic, which is wrong.
19-big-endian-const.diff Suppress compilation warnings on big endian platform.
20-rename_stale_item_bug.diff This patch fixes 2 bugs in reiserfs_rename(). First one being attempt to access item before verifying it was not moved since last access. Second is a window, where old filename may be written to disk with 'visible' flag unset without these changes be journaled.
21-reiserfs-inode_cache-fixed.diff reiserfs_inode_cache seems to be too long. converting it to reiser_inode_cache.
22-expanding-truncate-5.diff This patch makes sure that indirect pointers for holes are correctly filled in by zeroes at hole-creation time. (Author is Chris Mason. fs/buffer.c (generic_cont_expand) were written by Alexander Viro)
23-romount-nobug-onclose.diff Somebody introduced a bug in reiserfs_release_file() leading to corrupting journal for ro filesystems.
24-reiserfs-boot-verbose.diff Do not print unsuccesful superblocks read warnings (if old or new one cannot be found). Print verbose journal info. Convert warnings to standard format.
25-mount-convert-fix.diff Fixes a case where v3.6 filesystem can get wrong magic after converting from v3.5 one.
diff -rup linux/fs/reiserfs/bitmap.c linux.patched/fs/reiserfs/bitmap.c --- linux/fs/reiserfs/bitmap.c Tue Nov 13 15:58:58 2001 +++ linux.patched/fs/reiserfs/bitmap.c Tue Nov 13 16:17:28 2001 @@ -103,6 +103,13 @@ void reiserfs_free_block (struct reiserf get_bit_address (s, block, &nr, &offset); + if (nr >= sb_bmap_nr (rs)) { + reiserfs_warning ("vs-4075: reiserfs_free_block: " + "block %lu is out of range on %s\n", + block, bdevname(s->s_dev)); + return; + } + /* mark it before we clear it, just in case */ journal_mark_freed(th, s, block) ; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |