Messages in this thread | | | Date | Thu, 24 Jan 2002 16:32:33 +0100 | From | Vojtech Pavlik <> | Subject | Re: [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4] |
| |
On Thu, Jan 24, 2002 at 07:27:41AM -0800, David Brownell wrote: > Quoth "Vojtech Pavlik" <vojtech@suse.cz>: > > On Wed, Jan 23, 2002 at 04:46:13PM -0800, David Brownell wrote: > > > What's the story on "driverfs" happening, by the way? Last I knew, the > > > PCI bits weren't yet ready. > > > > I'm not absolutely sure about the status of the PCI support, but it > > should be close to working. Anyway, the driverfs infrastructure itself > > is in place in 2.5, so even if the PCI part wasn't there, still we can > > convert USB and Input to it. > > Since all the USB HCDs use PCI, I think the 2.5.3-pre4 updates > (well timed :) are necessary to convert USB: HCDs first, then the > hub driver, then input. Or at least, that's how I understand things > right now -- I was waiting for a "finished" example to read! :)
> > > strncpy (buf, dev->devpath, min_t(size_t, size, sizeof dev->devpath)); > > > > > > Use like you'd use pci_dev->slot_name ... no mallocation necessary. > > > It's just the path from root hub down to device, /2/1/7 and so on: the > > > physical path, which stays the same so long as you don't recable your > > > tree of USB devices and hubs. > > > > > > I'd expect the typical "driverfs" path for a USB device to be the > > > path for the root hub (normally a PCI slot like 00:0f.3) followed by > > > what "devpath" now shows. > > > > Ahh, I see. This "devpath" entry wasn't available at the time I wrote > > the 'usb_make_path' function. This is of course much better. What's not > > very convenient for me right now is that it uses slashes instead of > > dots, which the input subsystem uses for delimiting busses from each > > other, like: > > > > isa0060/serio0/input0 - AT keyboard > > pci0:7.3/usb1:2.2/input0 - USB keboard > > > > Using slashes in place of the dots would make it quite a mess. The > > slashes are probably there because of usbdevfs, right? > > Driverfs -- since the hubs are part of the device hierarchy, > which shows up in the filesystem. Also that's what the code > it replaced did (in the hub driver). Maybe it should change > to use driverfs directly... :)
Ok, now that we have driverfs PCI in place, I'll keep usb_make_path for a while not to break input, and once both hcds and hubs are converted, I'll convert input.
-- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |