[lkml]   [2002]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: 2.4.17:Increase number of anonymous filesystems beyond 256?
    On Tuesday, 22. January 2002 14:28, Trond Myklebust wrote:
    > On Tuesday 22. January 2002 14:08, you wrote:
    > > So I still think that the reason for this is a check in the kernel, that
    > > prevents connections from ports > 1024.
    > Nope. It's the following hunk:
    > diff -ur -X dontdiff linux-2.4.9-18.3/net/sunrpc/pmap_clnt.c
    > linux-2.4.9-18.3-p3/net/sunrpc/pmap_clnt.c
    > --- linux-2.4.9-18.3/net/sunrpc/pmap_clnt.c Wed Jun 21 12:43:37 2000
    > +++ linux-2.4.9-18.3-p3/net/sunrpc/pmap_clnt.c Mon Jan 7 12:59:54 2002
    > @@ -189,7 +189,7 @@
    > struct rpc_clnt *clnt;
    > /* printk("pmap: create xprt\n"); */
    > - if (!(xprt = xprt_create_proto(proto, srvaddr, NULL)))
    > + if (!(xprt = xprt_create_proto(proto, srvaddr, NULL, 0)))
    > return NULL;
    > xprt->addr.sin_port = htons(RPC_PMAP_PORT);
    > The above change implies that the portmapper can always be run from an
    > insecure port.
    > It can if the purpose of the RPC call is trying to read off a port number
    > for an RPC service. If the idea is to register a new service, however, then
    > the portmapper demands that we use a secure port.
    > The fix would be to add an argument to the function pmap_create() in order
    > to allow rpc_register() to specify that the call to xprt_create_proto()
    > should set up the socket on a secure port.

    Thanks for the hint. I fixed pmap_create() according to your proposal and now
    nfsd works again.

    One more question about something I'd like to understand:
    Petes fix limits the number of anonymous mounts to 1279. There was a shorter
    patch from Andi Kleen which basically just replaced the search for a secure
    port from 800 downwards (in xprt.c, xprt_bindresvport() ) by a bind operation
    to any port (not just a secure one). Raising the count of elements of
    unnamed_dev_in_use in fs/super.c to eg 4096 resulted in the opportunity to
    mount as many NFS directories. Allthough this patch suffered from two NFS
    problems (the nfsd problem just discussed, as well as a problem when NFS
    mounting from another linux box) it showed a way to use a very large number
    of NFS mounts.

    Can somebody explain the major difference between both solutions? Why did you
    Pete base your patch on 4 new major device numbers whereas Andis patch did
    not need them? Are there any major drawbacks involved not doing so?

    Thanks Rainer
    Rainer Krienke
    Universitaet Koblenz,
    Rechenzentrum, Voice: +49 261 287 - 1312
    Rheinau 1, 56075 Koblenz, Germany Fax: +49 261 287 - 1001312
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:15    [W:0.057 / U:15.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site