Messages in this thread | | | Date | Mon, 21 Jan 2002 16:37:10 -0200 (BRST) | From | Marcelo Tosatti <> | Subject | Re: Linux 2.4.18-pre4 bonding driver... |
| |
On Thu, 17 Jan 2002, Trond Myklebust wrote:
> > Marcelo, > > Is this code from linux-2.4.18-pre4/drivers/net/bonding.c safe? > > static int bond_close(struct net_device *master) > { > write_lock_irqsave(&bond->lock, flags); > <snip> > bond_release_all(master); > > write_unlock_irqrestore(&bond->lock, flags); > > AFAICS 'bond_release_all()' calls a bunch of lower level networking > functions some of which do sleep. It does nothing to release the > bond->lock when this occurs.
They are not safe, indeed.
Have you tried to contact the driver authors ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |