lkml.org 
[lkml]   [2002]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] C undefined behavior fix
On Wed, Jan 02, 2002 at 12:41:28PM +0200, Momchil Velikov wrote:
> >>>>> "Florian" == Florian Weimer <fw@deneb.enyo.de> writes:
>
> Florian> Momchil Velikov <velco@fadata.bg> writes:
> >> - strcpy(namep, RELOC("linux,phandle"));
> >> + memcpy (namep, RELOC("linux,phandle"), sizeof("linux,phandle"));
>
> Florian> Doesn't this still trigger undefined behavior, as far as the C
> Florian> standard is concerned? It's probably a better idea to fix the linker,
> Florian> so that it performs proper relocation.
>
> Well, strictly speaking it _is_ undefined, however adding/subtracting
> __PAGE_OFFSET is far too common operation and one can resonably expect
> to get away with it in the _vast_ majority of cases. IMHO, it is
> better to fix the particular case, which triggers the undefined
> behaviour, as these cases are bound to be _very_ rare.

IMHO the best thing is to change the RELOC macro, so that gcc cannot optimize
this.
E.g.:
-#define PTRRELOC(x) ((typeof(x))((unsigned long)(x) + offset))
+#define PTRRELOC(x) ({ unsigned long __x = (unsigned long)(x); \
asm ("" : "=r" (__x) : "0" (__x)); \
(typeof(x))(__x + offset); })
This way gcc cannot assume anything about it.

Jakub
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:15    [W:0.085 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site