[lkml]   [2002]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] I3 sched tweaks...
    In message <> 
    you write:
    > > 4) scheduler_tick needs no args (p is always equal to current).
    > i have not taken this part. We have 'current' calculated in
    > update_process_times(), so why not pass it along to the scheduler_tick()
    > function?

    Because it's redundant. It's *always* p == current (and the code
    assumes this!), but I had to grep the callers to find out.

    Moreover, the function doesn't make *sense* if p != current...

    > > 3) lock_task_rq returns the rq, rather than assigning it, for clarity.
    > i've made it an inline function instead of a macro.

    I thought of that, but assumed you had a good reason for making it a
    macro in the first place...

    Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:18    [W:0.040 / U:17.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site