Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] I3 sched tweaks... | Date | Wed, 16 Jan 2002 21:34:39 +1100 |
| |
In message <Pine.LNX.4.33.0201160412180.24929-100000@devserv.devel.redhat.com> you write: > > 4) scheduler_tick needs no args (p is always equal to current). > > i have not taken this part. We have 'current' calculated in > update_process_times(), so why not pass it along to the scheduler_tick() > function?
Because it's redundant. It's *always* p == current (and the code assumes this!), but I had to grep the callers to find out.
Moreover, the function doesn't make *sense* if p != current...
> > 3) lock_task_rq returns the rq, rather than assigning it, for clarity. > > i've made it an inline function instead of a macro.
I thought of that, but assumed you had a good reason for making it a macro in the first place...
Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |