lkml.org 
[lkml]   [2002]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux 2.5 and ppa.c
On Tue, Jan 15 2002, Douglas Gilbert wrote:
> John Weber <weber@nyc.rr.com> wrote:
>
> > This is one of those drivers still broken due to
> > the BIO changes (it still calls io_request_lock()).
> >
> > Unfortunately, I only know enough to
> > s/io_request_lock/host->host_lock/g.
> >
> > I am afraid this requires a little more than this.
>
> John,
> The ppa_detect() must _not_ take the host_lock semaphore
> as it is already taken by the mid level before it calls
> ppa_detect(). [This will cause a lock up on an SMP
> machine.]

Not true in 2.5, detect is called without any locks held.

> The ppa_interrupt() should take the host_lock semaphore
> before it calls scsi_done() (which calls up the scsi
> driver stack).

True

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:23    [W:0.053 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site