lkml.org 
[lkml]   [2002]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: buffer.c lock_kernel() -- removal


On Thu, 10 Jan 2002, Craig Christophel wrote:

> Included is a patch against buffer.c that removes the
> lock_kernel()/unlock_kernel() pairs in the few functions that they exist.
>
> This is for 2.5>2.5.2-pre10.
>
> I beleive that I checked all of the member functions for locking schematics
> but if you can prove me wrong -- go for it. The only issue I can see would

... and in the very first chunk we have

> - lock_kernel();
> sync_inodes_sb(sb);
> DQUOT_SYNC(sb);
> lock_super(sb);
> if (sb->s_dirt && sb->s_op && sb->s_op->write_super)
> sb->s_op->write_super(sb);
> unlock_super(sb);
> - unlock_kernel();

i.e. method that used to have BKL loses it. Unless you are willing to post
the results of audit for all filesystems - sorry, no go.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.040 / U:6.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site