lkml.org 
[lkml]   [2002]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 1-2-3 GB
    Hugh Dickins wrote:
    > ...
    > The patch below seems to be enough to convince egcs-2.91.66 and
    > gcc-2.95.3 to use a "jb" comparison there.
    > ...
    > - for (j = 0; j < PTRS_PER_PMD ; j++) {
    > - prefetchw(pmd+j+(PREFETCH_STRIDE/16));
    > - free_one_pmd(pmd+j);
    > + for (md = pmd, emd = pmd + PTRS_PER_PMD; md < emd; md++) {
    > + prefetchw(md+(PREFETCH_STRIDE/16));
    > + free_one_pmd(md);

    You need to add a big fat comment here, describing the compiler
    problem, and the risks which attend any change to this code.

    -
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:15    [W:6.434 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site