Messages in this thread | | | Date | Thu, 10 Jan 2002 08:09:27 -0800 | From | Greg KH <> | Subject | Re: __FUNCTION__ - patch for USB |
| |
On Thu, Jan 10, 2002 at 12:52:57PM +0200, Vladimir Kondratiev wrote: > Patch against 2.4.18-pre2 attached. For 2.5 tree - wait a bit, I have to > return for a moment to business I get salary for.
You still are changing a few dbg() macros that you don't have to change.
Also, info(), warn() and err() should not have __FUNCTION__ added to them. Have you tried running the usb code with this patch? The USB group gets enough grief about all of the kernel log messages that we spit out. We do not need to see the function name for every message we write (the user does not need it.)
I think I'll wait for the debug level messages cleanup in the 2.5 USB code to make this kind of change (as talked about in a previous message.)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |