Messages in this thread Patch in this message |  | | Date | Thu, 6 Sep 2001 02:04:51 +0100 (BST) | From | Dave Jones <> | Subject | [PATCH] Machine Check Exception thinko. |
| |
Hi all, The values printed by the bluesmoke exception handler are bogus. We're printing the address twice, instead of the address + the misc register as the intel spec defines. (I guess the reports we've had where the two values reported differing are down to the CPU being in a sorry state).
I'm surprised I didn't notice this whilst doing my recent 'use the MSR #defines' diff, and thought for a second I had introduced it with that patch, but I checked, and this bug existed before I did that, I just 'reimplemented' it.
If this patch is correct, and I'm not missing something here, all previously hand-decoded reports on Linux-kernel have been incorrect. (oops!)
As a side-note, I'm interested in any dumped Machine Check Exception logs, as I've started a tool to parse these into plaintext, and the more real world test cases the better.
Patch below.
regards,
Dave.
diff -urN --exclude-from=/home/davej/.exclude linux-ac/arch/i386/kernel/bluesmoke.c linux-dj/arch/i386/kernel/bluesmoke.c --- linux-ac/arch/i386/kernel/bluesmoke.c Thu Sep 6 01:10:08 2001 +++ linux-dj/arch/i386/kernel/bluesmoke.c Thu Sep 6 01:19:03 2001 @@ -38,7 +38,7 @@ high&=~(1<<31); if(high&(1<<27)) { - rdmsr(MSR_IA32_MC0_ADDR+i*4, alow, ahigh); + rdmsr(MSR_IA32_MC0_MISC+i*4, alow, ahigh); printk("[%08x%08x]", alow, ahigh); } if(high&(1<<26))
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs .
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |