This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Mon Oct 2 11:06:23 2023 Received: from spaans.ds9a.nl (adsl-xs4all.ds9a.nl [213.84.159.51]) by kylie.puddingonline.com (8.11.6/8.11.6) with SMTP id g8IEuEX22853 for ; Wed, 18 Sep 2002 16:56:15 +0200 Received: (qmail 3749 invoked from network); 18 Sep 2002 06:55:46 -0000 Received: from unknown (HELO spaans.ds9a.nl) (3ffe:8280:10:360:202:44ff:fe2a:a1dd) by mayo.ipv6.ds9a.nl with SMTP; 18 Sep 2002 06:55:46 -0000 Received: (qmail 13495 invoked by uid 1000); 17 Sep 2002 20:30:31 -0000 Received: (maildatabase); juh Received: (qmail 760 invoked by alias); 30 Sep 2001 20:32:55 -0000 Received: (qmail 757 invoked from network); 30 Sep 2001 20:32:55 -0000 Received: from vvtp.tn.tudelft.nl (HELO vvtp.nl) (qmailr@130.161.252.29) by spaans.ds9a.nl with SMTP; 30 Sep 2001 20:32:55 -0000 Received: (qmail 17239 invoked by uid 2547); 30 Sep 2001 20:31:25 -0000 Received: (qmail 16900 invoked from network); 30 Sep 2001 20:31:21 -0000 Received: from vger.kernel.org (199.183.24.194) by vvtp.tn.tudelft.nl with SMTP; 30 Sep 2001 20:31:21 -0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 30 Sep 2001 16:29:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 30 Sep 2001 16:28:59 -0400 Received: from air-1.osdlab.org ([65.201.151.5]:6675 "EHLO osdlab.pdx.osdl.net") by vger.kernel.org with ESMTP id ; Sun, 30 Sep 2001 16:28:50 -0400 Received: from osdlab.org (dragon.pdx.osdl.net [172.20.1.27]) by osdlab.pdx.osdl.net (8.11.2/8.11.2) with ESMTP id f8UKT3S26604; Sun, 30 Sep 2001 13:29:03 -0700 Message-Id: <3BB77FD7.696CFC58@osdlab.org> Date: Sun, 30 Sep 2001 13:25:59 -0700 From: "Randy.Dunlap" Organization: OSDL X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.4.3-20mdk i686) X-Accept-Language: en Mime-Version: 1.0 To: mingo@elte.hu, linux-kernel@vger.kernel.org, linux-net@vger.kernel.org, netdev@oss.sgi.com, jgarzik@mandrakesoft.com Subject: Re: [patch] netconsole-2.4.10-B1 References: <3BB77591.C1349C09@osdlab.org> Content-Type: multipart/mixed; boundary="------------BC742B6CC3660A9A3E7C6B46" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) This is a multi-part message in MIME format. --------------BC742B6CC3660A9A3E7C6B46 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Randy.Dunlap" wrote: > > Ingo Molnar wrote: > > > > > > does it make more sense now? :) > > Thanks for the definitions. I can work with them, > although I think that there's much room for improvement... and I did. Eliminating typos on 'insmod netconsole.o ...' helps. :) Here's 3c59x.c patched for netconsole (HAVE_POLL_CONTROLLER). Ingo, you _are_ planning to use most or all of Andreas's patches, aren't you? I'm interested in using netconsole early (during boot). Any problems doing that, other than getting module parameters to it? I can fix that part. ~Randy --------------BC742B6CC3660A9A3E7C6B46 Content-Type: text/plain; charset=us-ascii; name="3c59x-poll.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="3c59x-poll.patch" --- linux/drivers/net/3c59x.c.org Sun Aug 12 12:27:18 2001 +++ linux/drivers/net/3c59x.c Sun Sep 30 12:37:39 2001 @@ -842,6 +842,7 @@ static int vortex_ioctl(struct net_device *dev, struct ifreq *rq, int cmd); static void vortex_tx_timeout(struct net_device *dev); static void acpi_set_WOL(struct net_device *dev); +static void vorboom_poll(struct net_device *dev); /* This driver uses 'options' to pass the media type, full-duplex flag, etc. */ /* Option count limit only -- unlimited interfaces are supported. */ @@ -1328,6 +1329,9 @@ dev->set_multicast_list = set_rx_mode; dev->tx_timeout = vortex_tx_timeout; dev->watchdog_timeo = (watchdog * HZ) / 1000; +#ifdef HAVE_POLL_CONTROLLER + dev->poll_controller = &vorboom_poll; +#endif if (pdev && vp->enable_wol) { vp->pm_state_valid = 1; pci_save_state(vp->pdev, vp->power_state); @@ -2295,6 +2299,29 @@ handler_exit: spin_unlock(&vp->lock); } + +#ifdef HAVE_POLL_CONTROLLER + +/* + * Polling 'interrupt' - used by things like netconsole to send skbs + * without having to re-enable interrupts. It's not called while + * the interrupt routine is executing. + */ + +static void vorboom_poll (struct net_device *dev) +{ + struct vortex_private *vp = (struct vortex_private *)dev->priv; + + disable_irq(dev->irq); + if (vp->full_bus_master_tx) + boomerang_interrupt(dev->irq, dev, 0); + else + vortex_interrupt(dev->irq, dev, 0); + enable_irq(dev->irq); +} + +#endif + static int vortex_rx(struct net_device *dev) { --------------BC742B6CC3660A9A3E7C6B46-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/