Messages in this thread |  | | Date | Fri, 28 Sep 2001 15:14:54 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Patches to enable ia32 NUMA system (32 proc) |
| |
On Fri, 28 Sep 2001, Martin J. Bligh wrote: > > I've got rid of a few bugs (including my mail formatter). I think I've changed > what you wanted changed in here. I've also updated them to go against 2.4.10. > Please let me know of anything else you want changed.
The only thing I reacted to in these patches is:
> diff -urN virgin-2.4.10/init/main.c numa-2.4.10/init/main.c > --- virgin-2.4.10/init/main.c Thu Sep 20 21:02:01 2001 > +++ numa-2.4.10/init/main.c Thu Sep 27 11:57:21 2001 > @@ -490,9 +490,19 @@ > > #else > > +/* Where the IO area was mapped on multiquad, always 0 otherwise */ > +void *xquad_portio = NULL; ...
This is _definitely_ the wrong place to have magic x86-only code.
Why don't you just move that into the top of smp_boot_cpus()?
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |