Messages in this thread |  | | Date | Wed, 26 Sep 2001 16:49:35 +0200 | From | Andrea Arcangeli <> | Subject | Re: VM in 2.4.10(+tweaks) vs. 2.4.9-ac14/15(+stuff) |
| |
On Wed, Sep 26, 2001 at 11:23:44AM -0300, Rik van Riel wrote: > On Wed, 26 Sep 2001, Andrea Arcangeli wrote: > > On Wed, Sep 26, 2001 at 06:38:48AM -0700, Craig Kulesa wrote: > > > in memory, and is swapping out harder to compensate. The ac14/ac15 tree > > > > 2.4.10 is swapping out more also because I don't keep track of which > > pages are just uptodate on the swap space. This will be fixed as soon > > as I teach get_swap_page to collect away from the swapcache mapped > > exclusive swap pages. > > Wouldn't that be easier to do from try_to_swap_out() ?
Of course that's a possibility but then we'd have to duplicate it in all other get_swap_page callers, see?
And I think it much better fits hided in get_swap_page: the semantics of get_swap_page() are "give to the caller a newly allocated swap entry". So IMHO it is its own business to discard our "optimizations" to generate a free swap entry in case all swap was just allocated.
Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |