lkml.org 
[lkml]   [2001]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectPOSSIBLE BUG: 2.4.10 drivers/char/raw.c: Need help of maintainer/ guru
Date

Hi

I was going trough some usage patterns of brw_kiovec()
when I came across the main loop in dev.c:rw_raw_dev(). In
this loop, brw_kiovec() is called and the error code used
as bytes read or error detector [see at bottom].

However, if there is an error, err != iosize and the loop
will break. But it could happpen that the transferred variable
has been already set to something !0 (ie: in the second or
subsequent loop cycles), so the check in 371 is going to reset
err to a non-error value and return, thus the error is not
going to proagate up.

I just want to make sure, I don't know if this is a bug
or a feature ...

TIA

354 err = brw_kiovec(rw, 1, &iobuf, dev, iobuf->blocks,
sector_size);
355
356 if (rw == READ && err > 0)
357 mark_dirty_kiobuf(iobuf, err);
358
359 if (err >= 0) {
360 transferred += err;
361 size -= err;
362 buf += err;
363 }
364
365 unmap_kiobuf(iobuf);
366
367 if (err != iosize)
368 break;
369 }
370
371 if (transferred) {
372 *offp += transferred;
373 err = transferred;
374 }
375
376 out_free:
377 if (!new_iobuf)
378 clear_bit(0, &filp->f_iobuf_lock);
379 else
380 free_kiovec(1, &iobuf);
381 out:
382 return err;
383 }
384
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.030 / U:20.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site