Messages in this thread |  | | From | "Grover, Andrew" <> | Subject | ACPI sleep, proc error checking, and proc info patches | Date | Tue, 25 Sep 2001 14:24:34 -0700 |
| |
Hi Pavel,
I like the proc info and the error-checking patches. (although I think you meant to check against proc, not proc_entry, in a few places).
I don't like the sleep problem workaround. One, because it uses DMI information. The ACPI tables contain machine name and table version, and we want to use that, instead of DMI information that will not necessarily be updated when the BIOS is fixed. Two, I am extremely loathe to take workarounds for broken BIOSes. I know we don't have a blacklist at this point but I think having one would be cleaner - if *anything* is wrong, we shouldn't enable ACPI.
I admit, we *do* have one workaround in the code, for the PIIX4 C3 issue. That was a chipset problem, not an ACPI BIOS problem, and affected a huge number of machines.
ACPI BIOS problems usually are obviously wrong code, and I have had some success in getting vendors to fix them. If we do workarounds, vendors will never fix it. If we politely but insistently contact them and ask nicely, maybe they will, and if they don't, we can blacklist that table version for that machine.
So if you implement an ACPI bios blacklist I'd probably take that.
Regards -- Andy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |