lkml.org 
[lkml]   [2001]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: do we need 10 copies?
On Sun, 23 Sep 2001, Kai Germaschewski wrote:
> On Sun, 23 Sep 2001, Garst R. Reese wrote:
> > This table (512 bytes) and the code to implement crc-ccit is replicated
> > in 10 drivers. ppp-async even exports it. Surely there is a better way.
> As for the ISDN code (4 copies), there is the plan to use a a common HDLC
> en/decoding module, however that's a 2.5 thing. I'll take a look if I can
> find a generic solution then, but it might turn out difficult - having a
> module of its own just for that table wastes nearly a page, so that's
> probably worse than the current state of affairs.

I think the point is not so much that it tries to save memory, but
that it avoids duplicated code and errors. IIRC there were bugs in
previous kernels related to typos/errors in the individual crc tables...

-Dan
--
[-] Omae no subete no kichi wa ore no mono da. [-]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.058 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site