lkml.org 
[lkml]   [2001]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: linux-2.4.10-pre14/drivers/sound/maestro.c ignored pci_module_init results
In article <20010922230237.A10872@baldur.yggdrasil.com> you wrote:

> --M9NhX3UHpAaciwkO
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline

> The initialization routine in
> linux-2.4.10-pre14/drivers/sound/maestro.c ignores the return value
> from pci_module_init, and allows module initialization to succeed
> even if pci_module_init failed. pci_module_init fails and unloads
> the driver if the caller is a module and there is no matching hardware.
> Because maestro.c ignored this failure, loading maestro.o on a system
> where the corresponding alsa driver was already loaded or on a system
> without matchin hardware would result in a kernel null pointer dereference
> in pci_unregister_driver when the module is unloaded or when one
> attempts to reboot the system (i.e., when the module attempt to
> unregister a PCI driver that is not registered).

Why and where does it Oops? The code for pci_unregister_driver in
drivers/pci/pci.c looks correct and should not Oops.

The reboot notifier might be problematic, but I have not checked it.

Ciao, Marcus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:2.222 / U:4.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site