lkml.org 
[lkml]   [2001]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.4.10-pre13: ATM drivers cause panic
Alan Cox wrote:
> > Anyways, please find a (quick) patch below. It would be great if this patch or
> > any other similar could make it into the next release!
> > Thanks,
>
> That patch cannot possibly be correct. alloc_atm_dev sleeps

Actually there are a LOT of places that atm_dev_lock is held across sleeps -
I've been meaning to deal with them for awhile. Some of them are noted by
the Stanford checker, others are outside its reach (like calls into the
function pointers in atm_dev). I've been meaning to fix it once and for all
by turning that spinlock into a semaphore, but have not had a chance to
audit the code and make sure that it will be safe in all circumstances.
I need to trace all the interrupt paths and see what their locking needs
are.

I'm not at home tonight so I can't look at the code much right now, but
I'll try to sort out what the best fix is and forward it on to you.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.080 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site